[enhancement](macOS M1) Support building from source on macOS (M1)#13195
Merged
adonis0147 merged 7 commits intoapache:masterfrom Oct 18, 2022
Merged
[enhancement](macOS M1) Support building from source on macOS (M1)#13195adonis0147 merged 7 commits intoapache:masterfrom
adonis0147 merged 7 commits intoapache:masterfrom
Conversation
22a988b to
3251a50
Compare
3251a50 to
ff945ff
Compare
a39423b to
4bdea4b
Compare
4bdea4b to
1f66047
Compare
1f66047 to
9536414
Compare
125299d to
e8ad581
Compare
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
13 tasks
morningman
pushed a commit
that referenced
this pull request
Nov 18, 2022
#13195 left some unresolved issues. One of them is that some BE unit tests fail. This PR fixes this issue. Now, we can run the command ./run-be-ut.sh --run successfully on macOS.
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Nov 27, 2022
apache#13195 left some unresolved issues. One of them is that some BE unit tests fail. This PR fixes this issue. Now, we can run the command ./run-be-ut.sh --run successfully on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixed lots of issues when building from source on macOS with Apple M1 chip.
Validation Environment:
OS:
macOS Monterey
Compiler:
Apple clang version 14.0.0 (clang-1400.0.29.102)
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
ATTENTION
The job for supporting macOS with Apple M1 chip is too big and there are lots of unresolved issues during runtime:
...
This PR kicks off the job. Guys who are interested in this job can continue to fix these runtime issues.
Use case
Something else
It takes around 10+ minutes to build BE (with prebuilt third-parties) on macOS with M1 chip. We will improve the development experience on macOS greatly when we finish the adaptation job.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...