Skip to content

[enhancement](macOS M1) Support building from source on macOS (M1)#13195

Merged
adonis0147 merged 7 commits intoapache:masterfrom
adonis0147:apple-clang
Oct 18, 2022
Merged

[enhancement](macOS M1) Support building from source on macOS (M1)#13195
adonis0147 merged 7 commits intoapache:masterfrom
adonis0147:apple-clang

Conversation

@adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Oct 8, 2022

Proposed changes

This PR fixed lots of issues when building from source on macOS with Apple M1 chip.

Validation Environment:
OS:
macOS Monterey

Compiler:
Apple clang version 14.0.0 (clang-1400.0.29.102)
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

ATTENTION

The job for supporting macOS with Apple M1 chip is too big and there are lots of unresolved issues during runtime:

  1. Some errors with memory tracker occur when BE (RELEASE) starts.
  2. Some UT cases fail.
    ...

This PR kicks off the job. Guys who are interested in this job can continue to fix these runtime issues.

Use case

./build.sh -j 8 --be --clean

Something else

It takes around 10+ minutes to build BE (with prebuilt third-parties) on macOS with M1 chip. We will improve the development experience on macOS greatly when we finish the adaptation job.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes (Monterey (macOS 12.x) needs this commit)
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@adonis0147 adonis0147 force-pushed the apple-clang branch 4 times, most recently from 22a988b to 3251a50 Compare October 14, 2022 07:54
@adonis0147 adonis0147 changed the title [enhancement-wip](macOS M1) Support building from source on macOS (M1) [enhancement](macOS M1) Support building from source on macOS (M1) Oct 14, 2022
@hello-stephen
Copy link
Contributor

@hello-stephen
Copy link
Contributor

@adonis0147 adonis0147 force-pushed the apple-clang branch 4 times, most recently from a39423b to 4bdea4b Compare October 17, 2022 03:23
@github-actions github-actions bot added the area/sql/function Issues or PRs related to the SQL functions label Oct 17, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@adonis0147 adonis0147 merged commit 125def5 into apache:master Oct 18, 2022
@adonis0147 adonis0147 deleted the apple-clang branch October 18, 2022 06:45
@adonis0147 adonis0147 mentioned this pull request Nov 16, 2022
13 tasks
morningman pushed a commit that referenced this pull request Nov 18, 2022
#13195 left some unresolved issues. One of them is that some BE unit tests fail.
This PR fixes this issue. Now, we can run the command ./run-be-ut.sh --run successfully on macOS.
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Nov 27, 2022
apache#13195 left some unresolved issues. One of them is that some BE unit tests fail.
This PR fixes this issue. Now, we can run the command ./run-be-ut.sh --run successfully on macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants