Skip to content

[Enhancement](be-exec-version) add process when pblock.has_be_exec_version()=false #13256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BiteTheDDDDt wants to merge 1 commit into from
Closed

[Enhancement](be-exec-version) add process when pblock.has_be_exec_version()=false #13256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions be/src/vec/core/block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,14 @@ Block::Block(const std::vector<SlotDescriptor*>& slots, size_t block_size) {
}

Block::Block(const PBlock& pblock) {
CHECK(HeartbeatServer::check_be_exec_version(pblock.be_exec_version()));
int be_exec_version = 0;
if (pblock.has_be_exec_version()) {
be_exec_version = pblock.be_exec_version();
} else {
LOG(WARNING) << "pblock.has_be_exec_version()=false, maybe pblock not be serialized well, "
"or be version too old.";
}
CHECK(HeartbeatServer::check_be_exec_version(be_exec_version));

const char* buf = nullptr;
std::string compression_scratch;
Expand Down Expand Up @@ -100,7 +107,7 @@ Block::Block(const PBlock& pblock) {
for (const auto& pcol_meta : pblock.column_metas()) {
DataTypePtr type = DataTypeFactory::instance().create_data_type(pcol_meta);
MutableColumnPtr data_column = type->create_column();
buf = type->deserialize(buf, data_column.get(), pblock.be_exec_version());
buf = type->deserialize(buf, data_column.get(), be_exec_version);
data.emplace_back(data_column->get_ptr(), type, pcol_meta.name());
}
initialize_index_by_name();
Expand Down