Skip to content

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Oct 14, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

after expr rewrite, the sql will be re-analyzed. The reset method is called before re-analyze. The GroupByClause's reset method is not correct, this pr fix it.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@starocean999 starocean999 changed the title [fix](agg)the reseet the content of grouping exprs instead of replace it with original exprs [fix](agg) reset the content of grouping exprs instead of replace it with original exprs Oct 14, 2022
@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Oct 14, 2022
@dataalive
Copy link
Contributor

close #13350

@hello-stephen
Copy link
Contributor

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants