Skip to content

[Enhancement] replace assertTrue(X.equals(X)) with assertEquals#13387

Closed
ROTBOR wants to merge 0 commit intoapache:masterfrom
ROTBOR:master
Closed

[Enhancement] replace assertTrue(X.equals(X)) with assertEquals#13387
ROTBOR wants to merge 0 commit intoapache:masterfrom
ROTBOR:master

Conversation

@ROTBOR
Copy link
Contributor

@ROTBOR ROTBOR commented Oct 15, 2022

Proposed changes

Issue Number: close #11916

Problem summary

replace assertTrue(X.equals(X)) with assertEquals.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@jackwener
Copy link
Member

I suggest the you can use intellij IDEA open project. And IDEA will suggest it and auto fix it.

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ut failed, you can click FE and click login as a guest.
you can see which fe fail.

I don't recommend that you correct this PR by manually changing, Use IDEA auto fix, which will not cause error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] replace assertTrue(X.equals(X)) with assertEquals

3 participants