Skip to content

[fix](plugin) bugfix for dirty uninstallation of dynamic plugin (#13540)#13543

Merged
morningman merged 1 commit intoapache:masterfrom
dutyu:fix-dirty-uninstallation
Oct 21, 2022
Merged

[fix](plugin) bugfix for dirty uninstallation of dynamic plugin (#13540)#13543
morningman merged 1 commit intoapache:masterfrom
dutyu:fix-dirty-uninstallation

Conversation

@dutyu
Copy link
Contributor

@dutyu dutyu commented Oct 21, 2022

Proposed changes

Issue Number: close #13540

Problem summary

You can see detail at #13540 .

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@dutyu dutyu force-pushed the fix-dirty-uninstallation branch from 921da56 to b337a8f Compare October 21, 2022 10:04
@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.65 seconds
load time: 566 seconds
storage size: 17154644847 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221021215957_clickbench_pr_32553.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
Copy link
Contributor

#13619

@dutyu dutyu deleted the fix-dirty-uninstallation branch July 9, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PluginMgr may produce dirty uninstallation

4 participants