Skip to content

[Del](vec) Support in predicate in delete condition of or and#13587

Merged
Gabriel39 merged 1 commit intoapache:masterfrom
HappenLee:rf
Oct 25, 2022
Merged

[Del](vec) Support in predicate in delete condition of or and#13587
Gabriel39 merged 1 commit intoapache:masterfrom
HappenLee:rf

Conversation

@HappenLee
Copy link
Contributor

Proposed changes

selete from partition_tbl partition p10 where p1 in (5, 6, 7) and p2 != 6;

image

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Oct 24, 2022
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 24, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 41.49 seconds
load time: 604 seconds
storage size: 17154768673 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221024064251_clickbench_pr_32973.html

wangbo
wangbo previously approved these changes Oct 24, 2022
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 24, 2022
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 merged commit 2c70b17 into apache:master Oct 25, 2022
@dataalive dataalive added the usercase Important user case type label label Oct 27, 2022
morningman pushed a commit that referenced this pull request Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants