Skip to content

[Chore](build) add a environment variable DISABLE_JAVA_UDF#13588

Merged
Gabriel39 merged 3 commits intoapache:masterfrom
BiteTheDDDDt:dev_1024
Oct 25, 2022
Merged

[Chore](build) add a environment variable DISABLE_JAVA_UDF#13588
Gabriel39 merged 3 commits intoapache:masterfrom
BiteTheDDDDt:dev_1024

Conversation

@BiteTheDDDDt
Copy link
Contributor

Proposed changes

Currently we have no way to compile the backend without java-udf, which will cause us to spend 50s more per compilation, so I added an environment variable that disables java-udf.

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Gabriel39
Gabriel39 previously approved these changes Oct 24, 2022
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In build.sh line 292:
if [[ "${DISABLE_JAVA_UDF}" == "ON" ]]; then
       ^-----------------^ SC2154 (warning): DISABLE_JAVA_UDF is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- DISABLE_JAVA_UDF is referenced bu...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt ' found no issues.

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 merged commit bd884d3 into apache:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants