Skip to content

[Bug](decimal) Fix incorrect result for decimal multiply#13591

Merged
BiteTheDDDDt merged 3 commits intoapache:masterfrom
Gabriel39:fix_decimal
Oct 25, 2022
Merged

[Bug](decimal) Fix incorrect result for decimal multiply#13591
BiteTheDDDDt merged 3 commits intoapache:masterfrom
Gabriel39:fix_decimal

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Oct 24, 2022

Proposed changes

image

expected:
image

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/test approved Indicates a PR has been approved by one committer. labels Oct 24, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 7fe7c01 into apache:master Oct 25, 2022
liaoxin01 pushed a commit to liaoxin01/doris that referenced this pull request Nov 4, 2022
…apache#13548 apache#13591) (apache#931)

* update_hashes_with_value method should handle if input value is null apache#13332, fix tpch q75
  https://github.com/apache/doris/pull/13332/files
  commit 8301839
  Author: starocean999 <40539150+starocean999@users.noreply.github.com>
  Date:   Thu Oct 13 14:36:01 2022 +0800

* [Bug](sort) Fix bug in string sorter apache#13548, fix user case
  https://github.com/apache/doris/pull/13548/files
  commit a7c221d
  Author: Gabriel <gabrielleebuaa@gmail.com>
  Date:   Sat Oct 22 21:26:23 2022 +0800

* [Bug](decimal) Fix incorrect result for decimal multiply apache#13591, fix user case
  https://github.com/apache/doris/pull/13591/files
  commit 7fe7c01
  Author: Gabriel <gabrielleebuaa@gmail.com>
  Date:   Tue Oct 25 12:08:49 2022 +0800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants