Skip to content

[fix](rpc) The proxy removed when rpc exception occurs is not an abnormal proxy(#13836)#13943

Merged
yiguolei merged 1 commit intoapache:branch-1.1-ltsfrom
zenoyang:branch-1.1-lts_fix_rpc
Nov 3, 2022
Merged

[fix](rpc) The proxy removed when rpc exception occurs is not an abnormal proxy(#13836)#13943
yiguolei merged 1 commit intoapache:branch-1.1-ltsfrom
zenoyang:branch-1.1-lts_fix_rpc

Conversation

@zenoyang
Copy link
Member

@zenoyang zenoyang commented Nov 3, 2022

Proposed changes

Issue Number: close #xxx
BackendServiceProxy.getInstance() uses the round robin strategy to obtain the proxy,
so when the current RPC request is abnormal, the proxy removed by
BackendServiceProxy.getInstance().removeProxy(...) is not an abnormal proxy.

cherry pick:#13836

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zenoyang zenoyang force-pushed the branch-1.1-lts_fix_rpc branch from 2add68b to b5efe35 Compare November 3, 2022 08:23
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 2559414 into apache:branch-1.1-lts Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants