[feature-wip](multi-catalog) support partition&missing columns in parquet lazy read #14264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
Nov 14, 2022
be/src/exec/text_converter.h
Outdated
| bool write_vec_column(const SlotDescriptor* slot_desc, vectorized::IColumn* nullable_col_ptr, | ||
| const char* data, size_t len, bool copy_string, bool need_escape); | ||
| const char* data, size_t len, bool copy_string, bool need_escape, | ||
| size_t rows = 1); |
Contributor
There was a problem hiding this comment.
add comment in code to explain this magic num
be/src/exec/text_converter.hpp
Outdated
| } else { | ||
| nullable_column->get_null_map_data().push_back(0); | ||
| auto& null_map = nullable_column->get_null_map_data(); | ||
| null_map.resize_fill(null_map.size() + rows, 0); |
Contributor
There was a problem hiding this comment.
You need to modify the if code block in L333
| } | ||
| virtual ~GenericReader() = default; | ||
|
|
||
| bool fill_all_columns() const { return _fill_all_columns; } |
Contributor
There was a problem hiding this comment.
Add comment for interface.
Contributor
|
TeamCity pipeline, clickbench performance test result: |
AshinGau
force-pushed
the
lazy-pm
branch
2 times, most recently
from
a61c89a to
ff6685a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support partition&missing columns in parquet lazy read.
Problem summary
PR #13917 has supported lazy read for non-predicate columns in ParquetReader, but can't trigger lazy read when predicate columns are partition or missing columns. This PR support such case, and fill partition and missing columns in
FileReader.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...