Skip to content

[Bug](array-function) array set function not handle all null value#14318

Merged
yiguolei merged 3 commits intoapache:masterfrom
zhangstar333:bitmap_from_array
Nov 22, 2022
Merged

[Bug](array-function) array set function not handle all null value#14318
yiguolei merged 3 commits intoapache:masterfrom
zhangstar333:bitmap_from_array

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Nov 16, 2022

Proposed changes

Issue Number: close #14317

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 16, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.83 seconds
load time: 442 seconds
storage size: 17152605111 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221117063733_clickbench_pr_47690.html

xy720
xy720 previously approved these changes Nov 16, 2022
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 16, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xy720 xy720 added area/array-type Issues or PRs related to array type kind/fix Categorizes issue or PR as related to a bug. labels Nov 16, 2022
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 17, 2022
Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 21, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit 16d8a18 into apache:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/array-type Issues or PRs related to array type area/vectorization kind/fix Categorizes issue or PR as related to a bug. kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] array set function not handle all null value

5 participants