Skip to content

[refactor](decimalv3) Refine code for DecimalV3#14394

Merged
Gabriel39 merged 5 commits intoapache:masterfrom
Gabriel39:decimalv3
Nov 19, 2022
Merged

[refactor](decimalv3) Refine code for DecimalV3#14394
Gabriel39 merged 5 commits intoapache:masterfrom
Gabriel39:decimalv3

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Nov 18, 2022

Proposed changes

  1. Use a new Decimal128I to identify a Decimal128 type of DecimalV3
  2. Delete enable_decimalv3 from config.
  3. Rename Decimal128 in PrimitiveType to Decimal128I

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Nov 18, 2022
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 19, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 2c42f0a into apache:master Nov 19, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants