[feature](tools)profile viewer#14429
Merged
yiguolei merged 2 commits intoapache:masterfrom Nov 21, 2022
Merged
Conversation
morningman
reviewed
Nov 20, 2022
Contributor
morningman
left a comment
There was a problem hiding this comment.
Better to add a document for this tool.
you can add a document on Doris website to just point to the README file of this tools.
So that you can just maintain the README content in future, and no need to modify
the doc on website every time you update this tool.
Contributor
|
TeamCity pipeline, clickbench performance test result: |
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Nov 27, 2022
It is a painful work to read profile, especially there are multi-parallel instances. This tool helps us to grasp the main information of profile in a graphical view. The profile is represented by a tree. Sql operation nodes contains operation type(join, scan...), its node id, its fragment id. The number on the arrow edge means how many rows output by child node. This tool will sum the output rows of the same node in multi-parallel instances, that is if there are 4 parallel instance, and each ScanNode on lineitem table output 10 rows, the label on the arrow beginning with ScanNode(lineitem) is 40. Here is a demo for tpch Q2 tpch q2 profile viewer Issue Number: close #xxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
It is a painful work to read profile, especially there are multi-parallel instances.
This tool helps us to grasp the main information of profile in a graphical view.
The profile is represented by a tree.
Sql operation nodes contains operation type(join, scan...), its node id, its fragment id. The number on the arrow edge means how many rows output by child node. This tool will sum the output rows of the same node in multi-parallel instances, that is if there are 4 parallel instance, and each ScanNode on
lineitemtable output 10 rows, the label on the arrow beginning with ScanNode(lineitem) is 40.Here is a demo for tpch Q2
tpch q2 profile viewer
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...