[Feature](Kafka) Add kerberos support for kafka#14431
Merged
morningman merged 1 commit intoapache:masterfrom Nov 21, 2022
Merged
[Feature](Kafka) Add kerberos support for kafka#14431morningman merged 1 commit intoapache:masterfrom
morningman merged 1 commit intoapache:masterfrom
Conversation
amosbird
changed the title
Contributor
xiaokang
reviewed
Nov 21, 2022
| CPPFLAGS="-I${TP_INCLUDE_DIR}" \ | ||
| LDFLAGS="-L${TP_LIB_DIR}" \ | ||
| ./configure --prefix="${TP_INSTALL_DIR}" --enable-static --enable-shared=no --with-openssl="${TP_INSTALL_DIR}" --with-pic | ||
| ./configure --prefix="${TP_INSTALL_DIR}" --enable-static --enable-shared=no --with-openssl="${TP_INSTALL_DIR}" --with-pic --enable-gssapi="${TP_INSTALL_DIR}" --with-gss_impl=mit --with-dblib=none |
Contributor
There was a problem hiding this comment.
is '--with-dblib=none' needed?
Contributor
Author
There was a problem hiding this comment.
It helps exclude unneeded system dependencies (gdm in my case).
| # NOTE(amos): librdkafka uses a weird autoconf variant (mklove) which doesn't allow extending PKG_CONFIG with spaces in cmd. | ||
| # As a result, we use a patch to hard code "--static" into PKG_CONFIG instead. | ||
| # PKG_CONFIG="pkg-config --static" | ||
|
|
Contributor
There was a problem hiding this comment.
do we need to add --enable-gssapi for build_librdkafka?
Contributor
Author
There was a problem hiding this comment.
I don't think so. Linking to sasl2 will pull in all required archives.
Contributor
|
LGTM |
Contributor
|
We have tested in an env with kafka kerberos authentication, the issue #14431 is fixed. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
luwei16
pushed a commit
to luwei16/Doris
that referenced
this pull request
Apr 7, 2023
…e#1170) Compile librdkafka with Kerberos SASL GSSAPI support. Co-authored-by: Amos Bird <amosbird@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #14434 #14353
Problem summary
Compile librdkafka with Kerberos SASL GSSAPI support. cc @xiaokang
Checklist(Required)