Skip to content

[improvement](doc) add missing documents#14460

Merged
dataroaring merged 3 commits intoapache:masterfrom
morningman:branch12-doc
Nov 22, 2022
Merged

[improvement](doc) add missing documents#14460
dataroaring merged 3 commits intoapache:masterfrom
morningman:branch12-doc

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Nov 21, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

  1. There are some documents missed.
  2. Add instruction about how to write sql manual.
  3. Add a check for cancel load where state="xxx" stmt.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added the kind/docs Categorizes issue or PR as related to documentation. label Nov 21, 2022
@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Nov 21, 2022
@morningman morningman changed the title (improvement)[doc] add missing documents [improvement](doc) add missing documents Nov 21, 2022
@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.5 seconds
load time: 441 seconds
storage size: 17171066176 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221122053326_clickbench_pr_50470.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 6eeebd4 into apache:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants