Skip to content

[JavaUDF](loader) Fix compatible problem for JAVA 11#14519

Merged
yiguolei merged 2 commits intoapache:masterfrom
Gabriel39:fix_javaudf
Nov 23, 2022
Merged

[JavaUDF](loader) Fix compatible problem for JAVA 11#14519
yiguolei merged 2 commits intoapache:masterfrom
Gabriel39:fix_javaudf

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Nov 23, 2022

Proposed changes

close #14521

The class loader hierarchy has changed in Java 11 [1]. So current behavior is incorrect using Java 11.

[1] https://learn.microsoft.com/en-us/java/openjdk/transition-from-java-8-to-java-11#classloader-cautions

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 23, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.82 seconds
load time: 432 seconds
storage size: 17152312743 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221123134713_clickbench_pr_51648.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 23, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 496a92b into apache:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Compatible problem for JAVA 11

4 participants