Skip to content

[improvement](load) add more log on rpc error#14559

Merged
yiguolei merged 2 commits intoapache:masterfrom
zhannngchen:print-more-log-on-error
Nov 28, 2022
Merged

[improvement](load) add more log on rpc error#14559
yiguolei merged 2 commits intoapache:masterfrom
zhannngchen:print-more-log-on-error

Conversation

@zhannngchen
Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

A stream load failed, and we found the following log, which missed critical error message.
I guess it might be a rpc error and ErrorText is empty, add more logs.

W1124 16:39:14.329555 874006 tablet_sink.cpp:158] VNodeChannel[2869579-10003], load_id=5c4bf7fcacae1dd8-9a8c82bdc624695, txn_id=2120726589419520, node=172.29.123.127:8060, **, host: 172.29.123.127**
W1124 16:39:15.866672 874004 tablet_sink.cpp:158] VNodeChannel[2869579-10004], load_id=5c4bf7fcacae1dd8-9a8c82bdc624695, txn_id=2120726589419520, node=172.29.123.126:8060, **, host: 172.29.123.127**

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Nov 24, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.14 seconds
load time: 422 seconds
storage size: 17123356666 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221126115752_clickbench_pr_53474.html

@zhannngchen zhannngchen force-pushed the print-more-log-on-error branch 3 times, most recently from 2adfe64 to 77ee5c2 Compare November 26, 2022 07:38
@zhannngchen zhannngchen force-pushed the print-more-log-on-error branch from 77ee5c2 to b5059ef Compare November 26, 2022 11:36
Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit a0327ec into apache:master Nov 28, 2022
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2022
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

mrhhsg pushed a commit to mrhhsg/doris that referenced this pull request Nov 28, 2022
* [improvement](load) add more log on rpc error

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants