Skip to content

[fix](metric) fix metric jvm_xxx_size_bytes{type=max, ...}#14562

Merged
yiguolei merged 1 commit intoapache:masterfrom
dutyu:fix-metric-jvm_young_size_bytes
Nov 29, 2022
Merged

[fix](metric) fix metric jvm_xxx_size_bytes{type=max, ...}#14562
yiguolei merged 1 commit intoapache:masterfrom
dutyu:fix-metric-jvm_young_size_bytes

Conversation

@dutyu
Copy link
Copy Markdown
Contributor

@dutyu dutyu commented Nov 24, 2022

Proposed changes

Problem summary

If there is no limit for max young or old gen size, jvm_xxx_size_bytes{type=max, ...} should be max heap size, otherwise the graph would be a little wired.

image

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Nov 24, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.38 seconds
load time: 427 seconds
storage size: 17123062447 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221128093600_clickbench_pr_54316.html

@dutyu dutyu changed the title [fix](metric) fix jvm_young_size_bytes. [fix](metric) fix metric jvm_xxx_size_bytes{type=max, ...} Nov 28, 2022
@dutyu dutyu force-pushed the fix-metric-jvm_young_size_bytes branch from bfcb545 to 38085ba Compare November 28, 2022 01:52
@dutyu dutyu force-pushed the fix-metric-jvm_young_size_bytes branch from 38085ba to e11404d Compare November 28, 2022 08:09
Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 2295ab2 into apache:master Nov 29, 2022
@dutyu dutyu deleted the fix-metric-jvm_young_size_bytes branch July 9, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants