[fix](Dictionary-codec) heap overflow with in-predicate on nullable columns (#14319)#14641
Merged
BiteTheDDDDt merged 1 commit intoapache:masterfrom Nov 29, 2022
Conversation
Contributor
|
TeamCity pipeline, clickbench performance test result: |
freemandealer
force-pushed
the
updated_new_dict_heap_overflow
branch
from
ade35a4 to
fa943b5
Compare
…olumns (apache#14319) Losing segmentid info will mess up the _segment_id_to_value_in_dict_flags map in InListPredicate, causing two distinct segments to collide and crash the BE at last. Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
freemandealer
force-pushed
the
updated_new_dict_heap_overflow
branch
from
fa943b5 to
c48cb47
Compare
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
11 tasks
Contributor
|
need merge this to 1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Losing segmentid info will mess up the _segment_id_to_value_in_dict_flags map in InListPredicate,
causing two distinct segments to collide and crash the BE at last.
Root causes of the problem:
So overrided set function should be provided instead of use the dummy virtual one in the base class.
Signed-off-by: freemandealer freeman.zhang1992@gmail.com
Co-authored-by: Pxl pxl290@qq.com
Proposed changes
Issue Number: close #14319
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...