Skip to content

[fuzzy](test) be fuzzy conf#14654

Merged
yiguolei merged 3 commits intoapache:masterfrom
hello-stephen:be-fuzzy
Nov 29, 2022
Merged

[fuzzy](test) be fuzzy conf#14654
yiguolei merged 3 commits intoapache:masterfrom
hello-stephen:be-fuzzy

Conversation

@hello-stephen
Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

add be conf enable_fuzzy_mode for test.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Copy Markdown
Contributor Author

hello-stephen commented Nov 28, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.14 seconds
load time: 437 seconds
storage size: 17123391330 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221129080633_clickbench_pr_54854.html

Comment thread be/src/common/configbase.cpp Outdated

void set_fuzzy_configs() {
// random value true or false
Status s = set_fuzzy_config("enable_storage_vectorization",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fuzzy this variable, maybe some code could not run under non-vectorization engine.

I think you could fuzzy disable storage page cache.

Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Nov 29, 2022
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 22883e7 into apache:master Nov 29, 2022
@hello-stephen hello-stephen deleted the be-fuzzy branch November 29, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants