Skip to content

[refactor](datev2) refine function expr for datev2#14697

Merged
yiguolei merged 2 commits intoapache:masterfrom
Gabriel39:refine_datev2
Dec 2, 2022
Merged

[refactor](datev2) refine function expr for datev2#14697
yiguolei merged 2 commits intoapache:masterfrom
Gabriel39:refine_datev2

Conversation

@Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Gabriel39 Gabriel39 marked this pull request as draft November 30, 2022 06:20
@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Nov 30, 2022
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 30, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.91 seconds
load time: 431 seconds
storage size: 17123343163 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221201094747_clickbench_pr_56159.html

@Gabriel39 Gabriel39 marked this pull request as ready for review December 1, 2022 09:20
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit e9799fa into apache:master Dec 2, 2022
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Dec 15, 2022
* [refactor](datev2) refine function expr for datev2

* update
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Dec 18, 2022
* [refactor](datev2) refine function expr for datev2

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner dev/1.2.1-merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants