Skip to content

[fix](DOE) Support ES index which contains dynamic_templates#14762

Merged
yiguolei merged 3 commits intoapache:masterfrom
qidaye:doe_mapping_bug
Dec 5, 2022
Merged

[fix](DOE) Support ES index which contains dynamic_templates#14762
yiguolei merged 3 commits intoapache:masterfrom
qidaye:doe_mapping_bug

Conversation

@qidaye
Copy link
Contributor

@qidaye qidaye commented Dec 2, 2022

Proposed changes

Issue Number: close #14761

Problem summary

Support ES index with dynamic_templates. And do not support index mapping without explicit mapping.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 2, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 37.31 seconds
load time: 492 seconds
storage size: 17123343113 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221202101829_clickbench_pr_56867.html

Copy link
Contributor

@stalary stalary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 5be8f94 into apache:master Dec 5, 2022
@qidaye qidaye deleted the doe_mapping_bug branch December 5, 2022 02:05
morningman pushed a commit that referenced this pull request Dec 14, 2022
Support ES index with dynamic_templates. And do not support index mapping without explicit mapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/error-code dev/1.2.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] DOE query error when index mapping has dynamic_template

5 participants