Skip to content

[enhancement](regression) don't terminate when encountering one stmt exception#14791

Merged
dataroaring merged 1 commit intoapache:masterfrom
ByteYue:regression_frame
Dec 5, 2022
Merged

[enhancement](regression) don't terminate when encountering one stmt exception#14791
dataroaring merged 1 commit intoapache:masterfrom
ByteYue:regression_frame

Conversation

@ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Dec 3, 2022

Proposed changes

Issue Number: close #xxx
Previously one sql file consisting of multi stmts might terminate immediately once encountering one exception regardless the remaining untested stmts. This pr aims to make the framework return only when all the stmts of the sql file are tested.

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants