[fix](multi-catalog) fix persist issue about jdbc catalog and class loader issue#14794
Merged
yiguolei merged 1 commit intoapache:masterfrom Dec 5, 2022
Merged
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
TeamCity pipeline, clickbench performance test result: |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
morningman
force-pushed
the
fix_jdbc_catalog_persist
branch
2 times, most recently
from
45801a9 to
9351532
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
morningman
force-pushed
the
fix_jdbc_catalog_persist
branch
from
9351532 to
2ab7b87
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
morningman
added a commit
that referenced
this pull request
Dec 4, 2022
…oader issue (#14794) 1. Fix a bug that JDBC catalog/database/table should be add to GsonUtil 2. Fix a class loader issue that sometime it will cause ClassNotFoundException 3. Fix regression test to use different catalog name. 4. Comment out 2 regression tests: - regression-test/suites/query_p0/system/test_query_sys.groovy - regression-test/suites/statistics/alter_col_stats.groovy Need to be fixed later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Fix a bug that JDBC catalog/database/table should be add to GsonUtil
Fix a class loader issue that sometime it will cause ClassNotFoundException
Fix regression test to use different catalog name.
Comment out 2 regression tests:
Need to be fixed later
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...