[fix](schemachange) fix the schema change that causes the be core dump.#14804
Merged
yangzhg merged 5 commits intoapache:masterfrom Dec 8, 2022
Merged
[fix](schemachange) fix the schema change that causes the be core dump.#14804yangzhg merged 5 commits intoapache:masterfrom
yangzhg merged 5 commits intoapache:masterfrom
Conversation
github-actions
bot
added
area/planner
Contributor
|
TeamCity pipeline, clickbench performance test result: |
luozenglin
force-pushed
the
schema_change_fix
branch
from
9ba97ed to
1df2641
Compare
luozenglin
force-pushed
the
schema_change_fix
branch
4 times, most recently
from
a08d8f4 to
cf024b0
Compare
Forbid schema change to add or modify the key column of the agg model as double or float.
luozenglin
force-pushed
the
schema_change_fix
branch
from
cf024b0 to
ace42f2
Compare
yangzhg
reviewed
Dec 7, 2022
| } | ||
| for (AlterClause op : ops) { | ||
| if (op instanceof AlterTableClause && table instanceof OlapTable) { | ||
| ((AlterTableClause) op).setOlapTable((OlapTable) table); |
Member
There was a problem hiding this comment.
it better to table name no OlapTable object
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
pushed a commit
that referenced
this pull request
Dec 14, 2022
…p. (#14804) * [fix](schemachange) fix the schema change that causes the be core dump. Forbid schema change to add or modify the key column of the agg model as double or float.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forbid schema change to add or modify the key column of the agg model as double or float.
Proposed changes
Issue Number: close #14803
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...