Skip to content

[branch_1.1](compaction) add some log and fix promotion size bug#14819

Merged
dataroaring merged 1 commit intoapache:branch-1.1-ltsfrom
yixiutt:yixiu0007
Dec 5, 2022
Merged

[branch_1.1](compaction) add some log and fix promotion size bug#14819
dataroaring merged 1 commit intoapache:branch-1.1-ltsfrom
yixiutt:yixiu0007

Conversation

@yixiutt
Copy link
Contributor

@yixiutt yixiutt commented Dec 5, 2022

Proposed changes

cumulative_compaction_policy is global so it's member promotion size is shared by every tablet, this would make tablet
cumu promotion size incorrect

need pick to master.

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yixiutt yixiutt changed the title [branch_1.1](compaction) add some log [branch_1.1](compaction) add some log and fix promotion size bug Dec 5, 2022
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit bd9606d into apache:branch-1.1-lts Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants