[fix](nereids)having with no group by is not parsed correctly#14883
Merged
morrySnow merged 2 commits intoapache:masterfrom Dec 12, 2022
Merged
[fix](nereids)having with no group by is not parsed correctly#14883morrySnow merged 2 commits intoapache:masterfrom
morrySnow merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
TeamCity pipeline, clickbench performance test result: |
starocean999
force-pushed
the
master_perf
branch
4 times, most recently
from
6ba8f5f to
faa50ba
Compare
morrySnow
reviewed
Dec 11, 2022
Contributor
morrySnow
left a comment
morrySnow
left a comment
There was a problem hiding this comment.
please resolve conflict ~
starocean999
force-pushed
the
master_perf
branch
from
faa50ba to
175a853
Compare
morrySnow
approved these changes
Dec 12, 2022
| }); | ||
| }) | ||
| })), | ||
| RuleType.FILL_UP_HAVING_PROJECT.build( |
Contributor
There was a problem hiding this comment.
rule's name is better called HAVING_TO_FILTER
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...