Skip to content

[fix](planner) fix hll_union plan: Invalid Aggregate Operator: hll_union#14931

Merged
morningman merged 2 commits intoapache:masterfrom
zenoyang:1208_fix_hll
Dec 27, 2022
Merged

[fix](planner) fix hll_union plan: Invalid Aggregate Operator: hll_union#14931
morningman merged 2 commits intoapache:masterfrom
zenoyang:1208_fix_hll

Conversation

@zenoyang
Copy link
Member

@zenoyang zenoyang commented Dec 8, 2022

Proposed changes

Issue Number: close #xxx
When using hll_union aggregate function, PREAGGREGATION is always OFF and Rollup cannot be hit.

Problem summary

reproduce:

create table test.test_hll(
    dt date,
    id int,
    name char(10),
    province char(10),
    os char(10),
    pv hll hll_union
)
Aggregate KEY (dt,id,name,province,os)
distributed by hash(id) buckets 10
PROPERTIES(
    "replication_num" = "1",
    "in_memory"="false"
);

explain select dt, hll_union(pv) from test_hll group by dt;

output: TABLE: test_hll(null), PREAGGREGATION: OFF. Reason: Invalid Aggregate Operator: hll_union

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Dec 8, 2022
@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.05 seconds
load time: 424 seconds
storage size: 17123356265 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221208085427_clickbench_pr_60102.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 69068f9 into apache:master Dec 27, 2022
morningman pushed a commit that referenced this pull request Dec 27, 2022
…ion (#14931)

When using hll_union aggregate function, PREAGGREGATION is always OFF and Rollup cannot be hit.
zenoyang added a commit to zenoyang/doris that referenced this pull request Dec 28, 2022
…rator: hll_union (apache#14931)

When using hll_union aggregate function, PREAGGREGATION is always OFF and Rollup cannot be hit.
morningman pushed a commit that referenced this pull request Dec 28, 2022
…rator: hll_union (#14931) (#15425)

When using hll_union aggregate function, PREAGGREGATION is always OFF and Rollup cannot be hit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner dev/1.1.6-merged dev/1.2.1-merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants