[Fix](Table Valued function) fix the problem that can not catchthe exception thrown by the TableValuedFunctionRef constructor#14983
Merged
morningman merged 1 commit intoapache:masterfrom Dec 13, 2022
Conversation
github-actions
bot
added
the
area/planner
Contributor
|
TeamCity pipeline, clickbench performance test result: |
morningman
approved these changes
Dec 13, 2022
| try { | ||
| BrokerUtil.parseFile(path, brokerDesc, fileStatuses); | ||
| } catch (UserException e) { | ||
| throw new AnalysisException("parse file failed, path = " + path); |
| try { | ||
| s3uri = S3URI.create(validParams.get(S3_URI), forceVirtualHosted); | ||
| } catch (UserException e) { | ||
| throw new AnalysisException("parse s3 uri failed, uri = " + validParams.get(S3_URI)); |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
Please modify 2 minor problems in next PR |
morningman
pushed a commit
that referenced
this pull request
Dec 14, 2022
…ception thrown by the TableValuedFunctionRef constructor (#14983) Put the generation of TableValuedFunctionIf in the analyze function, instead of the generation in the TableValuedFunctionRef constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
fix the problem that can not catchthe exception thrown by the TableValuedFunctionRef constructor
Problem summary
Put the generation of
TableValuedFunctionIfin the analye function, instead of the generation in the TableValuedFunctionRef constructor.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...