[feature](file reader) Merge stream_load_pipe to the new file reader#15035
Merged
morningman merged 5 commits intoapache:masterfrom Dec 15, 2022
Merged
[feature](file reader) Merge stream_load_pipe to the new file reader#15035morningman merged 5 commits intoapache:masterfrom
morningman merged 5 commits intoapache:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| _proto_buffered_bytes(0), | ||
| _max_buffered_bytes(max_buffered_bytes), | ||
| _min_chunk_size(min_chunk_size), | ||
| _total_length(total_length), |
Contributor
There was a problem hiding this comment.
warning: member initializer '_total_length' does not name a non-static data member or base class [clang-diagnostic-error]
_total_length(total_length),
^
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
TeamCity pipeline, clickbench performance test result: |
morningman
reviewed
Dec 14, 2022
BePPPower
force-pushed
the
newStreamLoad2
branch
from
b3b0cbd to
88383bf
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #15456
Currently, there are two sets of file readers in Doris, this pr rewrites the old stream_load_pipe with the new file reader.
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...