Skip to content

[fix](remote) fix be crash while write data to s3 in debug mode #15047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pengxiangyu merged 1 commit into from
Dec 15, 2022
Merged

[fix](remote) fix be crash while write data to s3 in debug mode #15047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions be/src/io/fs/s3_file_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,22 @@ Status S3FileWriter::_upload_part() {
UploadPartOutcome upload_part_outcome = upload_part_callable.get();
_reset_stream();
if (!upload_part_outcome.IsSuccess()) {
return Status::IOError(
"failed to upload part (endpoint={}, bucket={}, key={}, part_num = {}): {}",
_s3_conf.endpoint, _s3_conf.bucket, _path.native(), _cur_part_num,
upload_part_outcome.GetError().GetMessage());
LOG(ERROR) << "failed to upload part (endpoint=" << _s3_conf.endpoint
<< ", bucket=" << _s3_conf.bucket << ", key=" << _path.native()
<< ", part_num=" << _cur_part_num
<< ") Error msg: " << upload_part_outcome.GetError().GetMessage();
return Status::IOError("failed to upload part.");
}

std::shared_ptr<CompletedPart> completed_part = std::make_shared<CompletedPart>();
completed_part->SetPartNumber(_cur_part_num);
auto etag = upload_part_outcome.GetResult().GetETag();
DCHECK(etag.empty());
if (etag.empty()) {
LOG(ERROR) << "upload part success but etag is empty (endpoint=" << _s3_conf.endpoint
<< ", bucket=" << _s3_conf.bucket << ", key=" << _path.native()
<< ", part_num=" << _cur_part_num << ")";
return Status::IOError("upload part success but etag is empty.");
}
completed_part->SetETag(etag);
_completed_parts.emplace_back(completed_part);
return Status::OK();
Expand Down