Skip to content

[BugFix](regression) don't use sf1DataPath when stream load#15060

Merged
BiteTheDDDDt merged 3 commits intoapache:masterfrom
ByteYue:fix_nereids_load_not_using_sf1
Dec 14, 2022
Merged

[BugFix](regression) don't use sf1DataPath when stream load#15060
BiteTheDDDDt merged 3 commits intoapache:masterfrom
ByteYue:fix_nereids_load_not_using_sf1

Conversation

@ByteYue
Copy link
Copy Markdown
Contributor

@ByteYue ByteYue commented Dec 14, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Dec 14, 2022
@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 14, 2022
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Dec 14, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.31 seconds
load time: 482 seconds
storage size: 17123356795 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221214033319_clickbench_pr_62991.html

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 14, 2022
@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 14, 2022
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit f17b138 into apache:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants