Skip to content

[Feature](Nereids)support mask function#15120

Merged
morrySnow merged 6 commits intoapache:masterfrom
sohardforaname:msk
Dec 21, 2022
Merged

[Feature](Nereids)support mask function#15120
morrySnow merged 6 commits intoapache:masterfrom
sohardforaname:msk

Conversation

@sohardforaname
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

support function for nereids: mask, mask_first_n, mask_last_n

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 15, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.69 seconds
load time: 640 seconds
storage size: 17123508788 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221220141656_clickbench_pr_65760.html

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u need add some regression test~

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 20, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 90349f0 into apache:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/nereids kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants