Skip to content

Comments

[chore](github) BE UT workflows support branch checks#15147

Merged
morningman merged 1 commit intoapache:branch-1.2-ltsfrom
adonis0147:branch-1.2-lts
Dec 17, 2022
Merged

[chore](github) BE UT workflows support branch checks#15147
morningman merged 1 commit intoapache:branch-1.2-ltsfrom
adonis0147:branch-1.2-lts

Conversation

@adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Dec 17, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

Apache Doris made the branch branch-1.2-lts protected. As a result, all pull requests for this branch should be checked before merging it.

However, the BE UT workflows doesn't support branch checks and they fail to check the pull requests for the branch branch-1.2-lts. The reason is that they download the wrong pre-built third-party libraries when they check the pull requests for branch-1.2-lts. This PR resolves this issue.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@adonis0147 adonis0147 marked this pull request as draft December 17, 2022 06:57
@adonis0147 adonis0147 marked this pull request as ready for review December 17, 2022 06:57
@morningman morningman merged commit 212ad34 into apache:branch-1.2-lts Dec 17, 2022
@adonis0147 adonis0147 deleted the branch-1.2-lts branch December 17, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants