Skip to content

[minor](non-vec) delete unused interface in RowBatch#15186

Merged
Gabriel39 merged 1 commit intoapache:masterfrom
zbtzbtzbt:master
Dec 20, 2022
Merged

[minor](non-vec) delete unused interface in RowBatch#15186
Gabriel39 merged 1 commit intoapache:masterfrom
zbtzbtzbt:master

Conversation

@zbtzbtzbt
Copy link
Contributor

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.95 seconds
load time: 633 seconds
storage size: 17123581394 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221219160810_clickbench_pr_65281.html

@Gabriel39 Gabriel39 changed the title delete unused interface in RowBatch [minor](non-vec) delete unused interface in RowBatch Dec 20, 2022
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 merged commit 9d48154 into apache:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants