Skip to content

[fix](compile) fix compile error caused by mysql_scan_node.cpp not being found when enabling WITH_MYSQL#15277

Merged
yangzhg merged 1 commit intoapache:masterfrom
luozenglin:compile_fix
Dec 23, 2022
Merged

[fix](compile) fix compile error caused by mysql_scan_node.cpp not being found when enabling WITH_MYSQL#15277
yangzhg merged 1 commit intoapache:masterfrom
luozenglin:compile_fix

Conversation

@luozenglin
Copy link
Contributor

@luozenglin luozenglin commented Dec 22, 2022

Proposed changes

Issue Number: close #15276

introduced by: #15239

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 22, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.25 seconds
load time: 679 seconds
storage size: 17123097295 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221223081257_clickbench_pr_67740.html

dataroaring
dataroaring previously approved these changes Dec 22, 2022
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 22, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 22, 2022
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@luozenglin luozenglin changed the title [fix](compile) fix compile error caused by mysql_scan_node.cpp not being found [fix](compile) fix compile error caused by mysql_scan_node.cpp not being found when enabling WITH_MYSQL Dec 23, 2022
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2022
@yangzhg yangzhg merged commit 8515a03 into apache:master Dec 23, 2022
morningman pushed a commit that referenced this pull request Dec 24, 2022
yangzhg added a commit to yangzhg/doris that referenced this pull request Dec 26, 2022
…pp` not being found when enabling `WITH_MYSQL` (apache#15277)"

This reverts commit 9d63753.
yangzhg added a commit that referenced this pull request Dec 26, 2022
…pp` not being found when enabling `WITH_MYSQL` (#15277)" (#15351)

This reverts commit 9d63753.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization dev/1.2.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] compile error caused by mysql_scan_node.cpp not being found

5 participants