Skip to content

[enhancement](regression) use sf0.1 data in datev2 and decimalv3 cases#15342

Merged
dataroaring merged 7 commits intoapache:masterfrom
ByteYue:use_more_sf0.1
Dec 26, 2022
Merged

[enhancement](regression) use sf0.1 data in datev2 and decimalv3 cases#15342
dataroaring merged 7 commits intoapache:masterfrom
ByteYue:use_more_sf0.1

Conversation

@ByteYue
Copy link
Copy Markdown
Contributor

@ByteYue ByteYue commented Dec 24, 2022

Proposed changes

Issue Number: close #xxx
Previously inside datev2 and decimalv3 we use one 1GB size data, now we can replace these cases with smaller size data to verify if the implementation of corresponding type is correct or not.

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

dataroaring
dataroaring previously approved these changes Dec 26, 2022
Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Dec 26, 2022
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Dec 26, 2022

It seems that the teamcity has skipped P1 regression tests, i'll run the related cases on my own environment and paste the cases result in future comment. Plz Don't Merge until the result has been published.

@github-actions github-actions Bot removed the approved Indicates a PR has been approved by one committer. label Dec 26, 2022
@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Dec 26, 2022

I've tested the related cases on my own environment.
image

@ByteYue ByteYue requested a review from dataroaring December 26, 2022 08:51
Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 72f0003 into apache:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants