Skip to content

[fix](new file reader) system_properties forgot to init broker_addresses#15417

Closed
zhannngchen wants to merge 1 commit intoapache:masterfrom
zhannngchen:fix-brokerload-core
Closed

[fix](new file reader) system_properties forgot to init broker_addresses#15417
zhannngchen wants to merge 1 commit intoapache:masterfrom
zhannngchen:fix-brokerload-core

Conversation

@zhannngchen
Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

This bug would cause be core while broker load.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.69 seconds
load time: 674 seconds
storage size: 17122453332 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221227194217_clickbench_pr_69723.html

@luozenglin
Copy link
Copy Markdown
Contributor

Same as: #15390

@zhannngchen
Copy link
Copy Markdown
Contributor Author

duplicate with #15390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants