Skip to content

[vectorized](jdbc) fix external table of oracle have keyworld column …#15487

Merged
morningman merged 2 commits intoapache:masterfrom
zhangstar333:fix-char-type
Dec 31, 2022
Merged

[vectorized](jdbc) fix external table of oracle have keyworld column …#15487
morningman merged 2 commits intoapache:masterfrom
zhangstar333:fix-char-type

Conversation

@zhangstar333
Copy link
Copy Markdown
Contributor

if column name is keyword of oracle, the query will report error

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Dec 29, 2022
@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Dec 29, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 37.09 seconds
load time: 712 seconds
storage size: 17123593238 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221230062101_clickbench_pr_71474.html

Copy link
Copy Markdown
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 31, 2022
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Copy link
Copy Markdown
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc is for jdbc but the code is for odbc?

@morningman
Copy link
Copy Markdown
Contributor

The doc is for jdbc but the code is for odbc?

Oh, it is for both jdbc and odbc

@morningman morningman merged commit c47bdf6 into apache:master Dec 31, 2022
morningman pushed a commit that referenced this pull request Dec 31, 2022
…15487)

if column name is keyword of oracle, the query will report error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/1.2.1-merged kind/docs Categorizes issue or PR as related to documentation. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants