Skip to content

[Fix](Nereids) Use correct column unique id when read data from non-base index.#15534

Merged
morrySnow merged 2 commits intoapache:masterfrom
wangshuo128:mv-unique-id
Jan 3, 2023
Merged

[Fix](Nereids) Use correct column unique id when read data from non-base index.#15534
morrySnow merged 2 commits intoapache:masterfrom
wangshuo128:mv-unique-id

Conversation

@wangshuo128
Copy link
Contributor

@wangshuo128 wangshuo128 commented Dec 30, 2022

Proposed changes

When light schema change is enabled by default, a column in OLAP scan is retrieved by column unique id instead of the column name. Columns with the same name would use different unique IDs among materialized indexes.
This PR ensures that the column in the OLAP scan node could use the correct column unique id.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/nereids area/planner Issues or PRs related to the query planner kind/test labels Dec 30, 2022
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 30, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.24 seconds
load time: 662 seconds
storage size: 17123633573 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230103120424_clickbench_pr_72878.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 18bc354 into apache:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/nereids area/planner Issues or PRs related to the query planner kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants