Skip to content

[fix](typo) Fix typo in variable name#15538

Merged
dataroaring merged 1 commit intoapache:masterfrom
Yukang-Lian:Fix_Typo
Jan 1, 2023
Merged

[fix](typo) Fix typo in variable name#15538
dataroaring merged 1 commit intoapache:masterfrom
Yukang-Lian:Fix_Typo

Conversation

@Yukang-Lian
Copy link
Collaborator

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 30, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.75 seconds
load time: 649 seconds
storage size: 17123035984 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221230164023_clickbench_pr_72113.html

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 7a433a1 into apache:master Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants