Skip to content

[bugfix](compaction) fix missing key_bounds in vertical compaction#15578

Merged
Gabriel39 merged 1 commit intoapache:masterfrom
yixiutt:yixiu0015
Jan 4, 2023
Merged

[bugfix](compaction) fix missing key_bounds in vertical compaction#15578
Gabriel39 merged 1 commit intoapache:masterfrom
yixiutt:yixiu0015

Conversation

@yixiutt
Copy link
Contributor

@yixiutt yixiutt commented Jan 3, 2023

When flush last segment of every column, missing set segment key bound for rowset meta so that rowset tree init error.

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

When flush last segment of every column, missing set segment key bound
for rowset meta so that rowset tree init error.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 3, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.35 seconds
load time: 654 seconds
storage size: 17123214308 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230103144344_clickbench_pr_73003.html

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 merged commit 73d4070 into apache:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants