Skip to content

[fix](nereids)type coercion: in-pred handle null literal bug#15595

Closed
englefly wants to merge 8 commits intoapache:masterfrom
englefly:in-null
Closed

[fix](nereids)type coercion: in-pred handle null literal bug#15595
englefly wants to merge 8 commits intoapache:masterfrom
englefly:in-null

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Jan 4, 2023

Proposed changes

fix two bug about nullLiteral

  1. fix type coercion bug
    1 in (2, null)
    in type coercion rewrite, nereids cast null to tiny int. This is wrong.

  2. NullLiteral should be passed as a function parameter of any data type.
    for example, sum(x) expects integerType as input parameter. But it also accept NullLiteral.
    We do not need to cast nullLiteral to Integer and then pass it to sum()

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a ut please~

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 4, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.27 seconds
load time: 489 seconds
storage size: 17122924951 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230112031223_clickbench_pr_78135.html

@englefly englefly force-pushed the in-null branch 4 times, most recently from 7e40e46 to f2ce056 Compare January 10, 2023 03:47
@englefly englefly marked this pull request as draft January 12, 2023 14:22
@morrySnow
Copy link
Contributor

fix by #15880

@morrySnow morrySnow closed this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments