[fix](nereids)type coercion: in-pred handle null literal bug#15595
Closed
englefly wants to merge 8 commits intoapache:masterfrom
Closed
[fix](nereids)type coercion: in-pred handle null literal bug#15595englefly wants to merge 8 commits intoapache:masterfrom
englefly wants to merge 8 commits intoapache:masterfrom
Conversation
Contributor
|
TeamCity pipeline, clickbench performance test result: |
morrySnow
reviewed
Jan 5, 2023
...core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/rules/TypeCoercion.java
Show resolved
Hide resolved
7e40e46 to
f2ce056
Compare
Contributor
|
fix by #15880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix two bug about nullLiteral
fix type coercion bug
1 in (2, null)in type coercion rewrite, nereids cast null to tiny int. This is wrong.
NullLiteral should be passed as a function parameter of any data type.
for example, sum(x) expects integerType as input parameter. But it also accept NullLiteral.
We do not need to cast nullLiteral to Integer and then pass it to sum()
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...