Skip to content

[add_log](checksum) add cost and size log for checksum#15599

Merged
dataroaring merged 1 commit intoapache:masterfrom
yixiutt:yixiu0016
Jan 4, 2023
Merged

[add_log](checksum) add cost and size log for checksum#15599
dataroaring merged 1 commit intoapache:masterfrom
yixiutt:yixiu0016

Conversation

@yixiutt
Copy link
Copy Markdown
Contributor

@yixiutt yixiutt commented Jan 4, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Copy Markdown
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.8 seconds
load time: 645 seconds
storage size: 17122532403 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230104095737_clickbench_pr_73371.html

Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 804ea08 into apache:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants