Skip to content

[improvement](pipeline) Support sharing hash table for broadcast join#15628

Merged
Gabriel39 merged 1 commit intoapache:masterfrom
mrhhsg:pipeline_share_hashtable
Jan 6, 2023
Merged

[improvement](pipeline) Support sharing hash table for broadcast join#15628
Gabriel39 merged 1 commit intoapache:masterfrom
mrhhsg:pipeline_share_hashtable

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Jan 4, 2023

Proposed changes

  1. FE chooses one instance to build hash table.
  2. Add EmptySourceOperator to adapt for HashJoinBuildSink which doesn't need to build hash table.

Problem Summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/vectorization labels Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 4, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.1 seconds
load time: 468 seconds
storage size: 17123236227 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230105104858_clickbench_pr_74154.html

@mrhhsg mrhhsg force-pushed the pipeline_share_hashtable branch from bd701e5 to 2bd14c0 Compare January 5, 2023 03:12
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

@mrhhsg mrhhsg force-pushed the pipeline_share_hashtable branch from 2bd14c0 to c6cf13b Compare January 5, 2023 07:39
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 9c36278 into apache:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner area/vectorization reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants