[fix](nereids) bind sort key priority problem#15646
Merged
morrySnow merged 5 commits intoapache:masterfrom Jan 10, 2023
Merged
Conversation
3caa85f to
d8ec070
Compare
0f5e76b to
75bd482
Compare
Contributor
|
TeamCity pipeline, clickbench performance test result: |
morrySnow
reviewed
Jan 8, 2023
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSlotReference.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSlotReference.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSlotReference.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSlotReference.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSlotReference.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSlotReference.java
Outdated
Show resolved
Hide resolved
db8c0b3 to
8075cb8
Compare
morrySnow
previously approved these changes
Jan 10, 2023
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
8075cb8 to
ad2b705
Compare
morrySnow
approved these changes
Jan 10, 2023
Contributor
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem summary
cases:
table t (int a, int b)
case1.
select a as b from t order by t.bcase2.
select a as b from t order by bcase3.
select a as b from t order by t.b + bTODO:
currently,
sort
+---project
+-----grandSon
sort key can be bound on project.output and grandSon.output.
But there are some cases in which sort key should be bound on the output of grandSon's children.
For example grandSon is
t1 join ( t2 join t3)
and order key is t3.x
case1.
select a as b from t group by t.bcase2.
select a as b from t group by bcase3.
select a as b from t group by t.b + bIssue Number: close #xxx
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...