[Pipeline](Exec) disable work steal of hash join build#15652
Merged
Gabriel39 merged 1 commit intoapache:masterfrom Jan 6, 2023
Merged
[Pipeline](Exec) disable work steal of hash join build#15652Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39 merged 1 commit intoapache:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
be/src/pipeline/pipeline.h
Outdated
| DCHECK(_complete_dependency < _dependencies.size()); | ||
| return _complete_dependency.fetch_add(1) == _dependencies.size() - 1; | ||
| bool finish = _complete_dependency.fetch_add(1) == _dependencies.size() - 1; | ||
| if (finish) _previous_schedule_id = dependency_core_id; |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (finish) _previous_schedule_id = dependency_core_id; | |
| if (finish) { _previous_schedule_id = dependency_core_id; | |
| } |
Contributor
|
TeamCity pipeline, clickbench performance test result: |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Opt the cache miss of hash join build side in pipe exe engine
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...