Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Jan 9, 2023

Proposed changes

Issue Number: close #xxx

Problem Summary

The template arguments are too complex, we need to simplify them before adding the implementation of PHMap.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@mrhhsg mrhhsg force-pushed the simplify_partitioned_hash_table branch from 16d2c32 to 50654da Compare January 9, 2023 09:38
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@jacktengg
Copy link
Contributor

LGTM

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.5 seconds
load time: 533 seconds
storage size: 17122232013 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230109130018_clickbench_pr_76158.html

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 4bbc93b into apache:master Jan 11, 2023
@mrhhsg mrhhsg deleted the simplify_partitioned_hash_table branch January 12, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants