Skip to content

[fix](QueryDetail) fix QueryDetail may be incorrect and null pointer exception#15765

Merged
yangzhg merged 2 commits intoapache:masterfrom
luozenglin:connext_fix
Jan 11, 2023
Merged

[fix](QueryDetail) fix QueryDetail may be incorrect and null pointer exception#15765
yangzhg merged 2 commits intoapache:masterfrom
luozenglin:connext_fix

Conversation

@luozenglin
Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #14937

Problem summary

If sql throws an exception during the analysis phase, it will not update the QueryDetail, which will cause the QueryDetail in the ConnectContext to be inaccurate, and if this happens during the connection, there will be a null pointer exception causing the connection to fail.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 10, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.59 seconds
load time: 489 seconds
storage size: 17122241897 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230110175530_clickbench_pr_77020.html

Copy link
Copy Markdown
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yangzhg yangzhg merged commit 18a3b75 into apache:master Jan 11, 2023
yangzhg pushed a commit that referenced this pull request Jan 11, 2023
…exception (#15765)

* [fix](QueryDetail) fix QueryDetail may be incorrect and null pointer exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/1.2.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [daily]pymysql execute lost connection when sql failed

4 participants