[refactor](remove row batch) remove impala rowbatch structure#15767
Merged
yiguolei merged 4 commits intoapache:masterfrom Jan 11, 2023
Merged
[refactor](remove row batch) remove impala rowbatch structure#15767yiguolei merged 4 commits intoapache:masterfrom
yiguolei merged 4 commits intoapache:masterfrom
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -24,7 +24,6 @@ | |||
| #include "exprs/expr.h" | |||
| #include "exprs/int_literal.h" | |||
Contributor
There was a problem hiding this comment.
warning: 'exprs/int_literal.h' file not found [clang-diagnostic-error]
#include "exprs/int_literal.h"
^| @@ -23,7 +23,6 @@ | |||
| #include "exprs/in_predicate.h" | |||
| #include "exprs/int_literal.h" | |||
Contributor
There was a problem hiding this comment.
warning: 'exprs/int_literal.h' file not found [clang-diagnostic-error]
#include "exprs/int_literal.h"
^
be/test/vec/exprs/vexpr_test.cpp
Outdated
| doris::vectorized::VExprContext* context = nullptr; | ||
| doris::vectorized::VExpr::create_expr_tree(&object_pool, exprx, &context); | ||
|
|
||
| int32_t k1 = -100; |
Contributor
There was a problem hiding this comment.
warning: unused variable 'k1' [clang-diagnostic-unused-variable]
int32_t k1 = -100;
^
Contributor
|
TeamCity pipeline, clickbench performance test result: |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...